Skip to content

Changed base image to audited Debian Base #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2018
Merged

Changed base image to audited Debian Base #41

merged 1 commit into from
Jul 3, 2018

Conversation

davidz627
Copy link
Contributor

Fixes: #15

/assign @msau42

@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali July 3, 2018 00:07
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2018
msau42
msau42 reviewed Jul 3, 2018
View reviewed changes
Dockerfile Outdated
# Install necessary dependencies
RUN apt-get update && apt-get install -y --no-install-recommends util-linux e2fsprogs mount ca-certificates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the k8s debian image, you can use the "clean-install" command instead of apt-get. And you don't need to run apt-get update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@davidz627 davidz627 force-pushed the fix/DeployImageCA branch from fa8c455 to 293e8ae Compare July 3, 2018 17:34
@davidz627
Copy link
Contributor Author

addressed comments

msau42
msau42 reviewed Jul 3, 2018
View reviewed changes
Dockerfile Outdated
# Install necessary dependencies
RUN clean-install -y --no-install-recommends util-linux e2fsprogs mount ca-certificates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the options, clean-install already runs with them
https://github.com/kubernetes/kubernetes/blob/master/build/debian-base/clean-install

@davidz627 davidz627 force-pushed the fix/DeployImageCA branch from 293e8ae to 57d69bc Compare July 3, 2018 20:08
@davidz627
Copy link
Contributor Author

davidz627 commented Jul 3, 2018 •
edited
Loading

comments addressed, thanks for the tips :)

@davidz627
Copy link
Contributor Author

/retest

@msau42
Copy link
Contributor

msau42 commented Jul 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1cc48a4 into kubernetes-sigs:master Jul 3, 2018
@davidz627 davidz627 deleted the fix/DeployImageCA branch July 3, 2018 21:19
dobsonj pushed a commit to dobsonj/gcp-compute-persistent-disk-csi-driver that referenced this pull request Oct 16, 2023
@openshift-merge-robot
Merge pull request kubernetes-sigs#41 from tsmetana/fix-forced-cgo-build
5856e47 
OCPBUGS-17367: UPSTREAM: <carry>: Remove the static library linking flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidz627 @k8s-ci-robot @msau42