Move all RePD compute API calls to v1 from v1beta #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
davidz627
force-pushed
the
fix/rePDAPI
branch
from
4839536 to
1f9ca24
Compare
|
/lgtm Now that we have gke regional cluster support, we could potentially add another storageclass test config to use Regional PDs in our external e2e tests. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could probably refactor out
CloudDiskas well as that was an artifact of having different objects of disks from different APIs. We could probably also consolidate a lot of the zonal/regional codepaths now that we don't need to use entirely different compute APIs.However, I've refrained from making large changes here in the interest of stability. Also I think theres a possibility we'd need to use different APIs again in the future so I've left the option for that open.
Fixes: #213
/kind cleanup
/assign @msau42