Skip to content

Add ListVolumes with PublishedNodes #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2019
Merged

Add ListVolumes with PublishedNodes #392

merged 2 commits into from
Nov 1, 2019

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Sep 27, 2019 •
edited
Loading

/kind feature
/assign @msau42

Adds LIST_VOLUMES and LIST_VOLUMES_PUBLISHED_NODES capabilities with respective functionality

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2019
@davidz627 davidz627 force-pushed the feature/listVolPublished branch from 34477a0 to f2d47d9 Compare October 1, 2019 18:15
@davidz627 davidz627 force-pushed the feature/listVolPublished branch from f2d47d9 to d527c3c Compare October 2, 2019 20:45
@davidz627 davidz627 force-pushed the feature/listVolPublished branch 2 times, most recently from 297cfa0 to 040f96e Compare October 4, 2019 21:30
@davidz627
Copy link
Contributor Author

@msau42 resolved comments and fixed tests

@davidz627 davidz627 changed the title WIP Add ListVolumes with PublishedNodes [WIP blocked on CSI Spec v1.2] Add ListVolumes with PublishedNodes Oct 4, 2019
msau42
msau42 reviewed Oct 4, 2019
View reviewed changes
Copy link
Contributor

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm

@davidz627 davidz627 force-pushed the feature/listVolPublished branch 2 times, most recently from 5e8d0d2 to f7b1597 Compare October 10, 2019 00:10
@davidz627 davidz627 force-pushed the feature/listVolPublished branch from f7b1597 to cfd3a35 Compare October 26, 2019 00:38
@davidz627 davidz627 changed the title [WIP blocked on CSI Spec v1.2] Add ListVolumes with PublishedNodes Add ListVolumes with PublishedNodes Oct 26, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 26, 2019
@davidz627 davidz627 force-pushed the feature/listVolPublished branch from cfd3a35 to c8e14f1 Compare October 26, 2019 00:41
@davidz627 davidz627 force-pushed the feature/listVolPublished branch from c8e14f1 to 5f48ffd Compare November 1, 2019 00:05
@davidz627
Copy link
Contributor Author

Updated to csi-test v2.4.0-rc1

@msau42
Copy link
Contributor

msau42 commented Nov 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2019
@davidz627
Copy link
Contributor Author

/retest

1 similar comment
@davidz627
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit fa208e7 into kubernetes-sigs:master Nov 1, 2019
@davidz627 davidz627 deleted the feature/listVolPublished branch November 1, 2019 21:05
@davidz627 davidz627 mentioned this pull request Mar 6, 2020
Closed
@joshimoo joshimoo mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@verult verult Awaiting requested review from verult

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidz627 @k8s-ci-robot @msau42