Skip to content

Fix resize test failure #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

Fix resize test failure #379

merged 1 commit into from
Aug 27, 2019

Conversation

verult
Copy link
Contributor

@verult verult commented Aug 20, 2019 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:
Fixes resize tests that was broken by #364

  • Replaced snapshotter and resizer RBAC namespace

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Locally verified with k8s master, with ExpandCSIVolumes feature gate enabled. Also manually verified resize operation with dev deployment.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2019
@msau42
Copy link
Contributor

msau42 commented Aug 20, 2019

/assign @davidz627

davidz627
davidz627 reviewed Aug 20, 2019
View reviewed changes
test/run-k8s-integration.sh Outdated
@@ -23,6 +23,7 @@ export GCE_PD_VERBOSITY=9
make -C ${PKGDIR} test-k8s-integration

base_cmd="${PKGDIR}/bin/k8s-integration-test \
--kube-feature-gates=\"ExpandCSIVolumes=true\"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this to the local script too (or a comment saying to bring up your cluster with this feature gate or it wont work if the script doesn't bring up a cluster)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually about to remove this, since we don't want resize test in latest yet

@verult verult changed the title Fix resize test failure; enable resize tests against latest Fix resize test failure Aug 20, 2019
@verult
Copy link
Contributor Author

verult commented Aug 22, 2019

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@davidz627
Copy link
Contributor

/retest

@davidz627
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4d5cf38 into kubernetes-sigs:master Aug 27, 2019
@davidz627
Copy link
Contributor

Looks like this turned the tests green, thanks @verult!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 davidz627 left review comments

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@verult @msau42 @davidz627 @k8s-ci-robot