Skip to content

Simple go verification scripts #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2018
Merged

Simple go verification scripts #35

merged 2 commits into from
Jun 28, 2018

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Jun 28, 2018 •
edited
Loading

Fixes #33

Add some simple go verification scripts like gofmt and govet.

Entrypoint is hack/verify-all. More verification scripts can be added later

test-infra change: kubernetes/test-infra#8500

/assign @msau42 @krzyzacy

@k8s-ci-robot
Copy link
Contributor

@davidz627: GitHub didn't allow me to assign the following users: krzyzacy.

Note that only kubernetes-sigs members and repo collaborators can be assigned.

In response to this:

Add some simple go verification scripts like gofmt and govet.

Entrypoint is hack/verify-all. More verification scripts can be added later

test-infra change: kubernetes/test-infra#8500

/assign @msau42 @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from msau42 June 28, 2018 22:41
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2018
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali June 28, 2018 22:41
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2018
krzyzacy
krzyzacy reviewed Jun 28, 2018
View reviewed changes
hack/update-gofmt.sh Outdated
@@ -0,0 +1,21 @@
#!/bin/bash

# Copyright 2017 The Kubernetes Authors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: 2018

@davidz627 davidz627 force-pushed the feature/verifyScripts branch from c666c09 to 005adf6 Compare June 28, 2018 22:45
krzyzacy
krzyzacy reviewed Jun 28, 2018
View reviewed changes
hack/verify-all.sh
PKG_ROOT=$(git rev-parse --show-toplevel)

${PKG_ROOT}/hack/verify-gofmt.sh
${PKG_ROOT}/hack/verify-govet.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: new line :-)

@davidz627 davidz627 force-pushed the feature/verifyScripts branch from 005adf6 to 9c861b9 Compare June 28, 2018 22:48
krzyzacy
krzyzacy approved these changes Jun 28, 2018
View reviewed changes
Copy link

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: changing LGTM is restricted to assignees, and only kubernetes-sigs/gcp-compute-persistent-disk-csi-driver repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42
Copy link
Contributor

msau42 commented Jun 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 560d854 into kubernetes-sigs:master Jun 28, 2018
@davidz627 davidz627 deleted the feature/verifyScripts branch June 28, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidz627 @k8s-ci-robot @msau42 @krzyzacy