Migrate to k8s integration tests to kubetest #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
davidz627
force-pushed
the
fix/migrateToKubetest
branch
from
5a2e8ca to
6e1cd9d
Compare
|
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
|
We lost the summary of each test case in the output: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/349/pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration/1151641109189890048/ |
msau42
reviewed
Jul 18, 2019
test/k8s-integration/main.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| homeDir, _ := os.LookupEnv("HOME") | ||
| os.Setenv("KUBECONFIG", filepath.Join(homeDir, ".kube/config")) | ||
|
|
||
| artifactsDir, _ := os.LookupEnv("ARTIFACTS") |
…ceties that I think will fix a lot of GCE config issues
davidz627
force-pushed
the
fix/migrateToKubetest
branch
from
6e1cd9d to
5831038
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/kind failing-test
/assign @msau42 @hantaowang
Alright this should just fix a bunch of stuff. Once it's done and stable I think there are a bunch of flags we can probably remove that were put in to work around the fact we weren't using kubetest :(