Add forced variable num-nodes so that we can give it to kubetest to force tests to run that have high node requirements #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce tests to run that have high node requirements
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
What is super weird is that I'm observing https://github.com/kubernetes/kubernetes/blob/a10eced56b9100c30489b10c7a01e685735f6f0b/test/e2e/e2e.go#L110 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind flake
For some reason some migration tests get skipped every once in a while because "number of nodes is not enough" when it only needs 2. For some reason the "num-nodes" variable in the e2e binary that's supposed to be dynamically gathered is showing
-1(indicating failure to dynamically get the read/schedulable nodes from api server sometimes) so to solve I provide the num nodes flag every time.I'm currently looking into why the e2e binary is not auto-setting this variable sometimes but that might be a larger fix
/assign @msau42
/cc @hantaowang