-
Notifications
You must be signed in to change notification settings - Fork 159
bugfix-222 Driver should check socket parent directory before trying … #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @zhucan! |
/retest |
/assign @davidz627 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for picking this up @zhucan! Just some minor comments, feel free to chat on slack (i'm davidz627) if you have any questions
copy that, thanks |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, zhucan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @zhucan! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
if the socket parent directory does not exit, the driver does not check it and just tries to call Listen to the address. So the error message returned from Listen call does not give the clear reason why it fail. It would be better to check whether the parent directory exist or not before listening to the socket address.
Which issue(s) this PR fixes:
Fixes #222
Special notes for your reviewer:
@jingxu97
@davidz627
Does this PR introduce a user-facing change?: