Skip to content

LOW PRIORITY Fix random lint errors #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

LOW PRIORITY Fix random lint errors #331

merged 1 commit into from
Jul 9, 2019

Conversation

davidz627
Copy link
Contributor

/kind cleanup

For Id -> ID see: https://github.com/golang/go/wiki/CodeReviewComments#initialisms

What this PR does / why we need it:
Fixes a bunch of random lint errors because its late and I don't want to think but I'm waiting for a ride.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from msau42 and verult July 4, 2019 00:38
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2019
@davidz627
Copy link
Contributor Author

/assign @hantaowang @msau42

@davidz627 davidz627 changed the title Fix random lint errors LOW PRIORITY Fix random lint errors Jul 4, 2019
@hantaowang
Copy link

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@hantaowang
Copy link

hantaowang commented Jul 4, 2019 •
edited
Loading

The test has failed twice now:
https://prow.k8s.io/?repo=kubernetes-sigs%2Fgcp-compute-persistent-disk-csi-driver&pull=331&author=davidz627
on different tests, with the rest skipped. But it seems like prow is just being weird.

@hantaowang
Copy link

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, hantaowang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidz627
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9eee065 into kubernetes-sigs:master Jul 9, 2019
@davidz627 davidz627 deleted the fix/lint branch July 9, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@verult verult Awaiting requested review from verult

Assignees

@hantaowang hantaowang

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidz627 @hantaowang @k8s-ci-robot @msau42