-
Notifications
You must be signed in to change notification settings - Fork 159
update gofmt to not search unnecessary places and report files changed #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hantaowang
commented
Jun 28, 2019
Hi @hantaowang. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -18,4 +18,4 @@ set -o errexit | |||
set -o nounset | |||
set -o pipefail | |||
|
|||
find . -name "*.go" | grep -v "\/vendor\/" | xargs gofmt -s -w | |||
find . -not -path "*/vendor/*" -not -path "./test/k8s-integration/src/*" -name "*.go" | xargs gofmt -s -w -l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ignore a whole directory tree, use -prune rather than checking every file in the tree. For example, to skip the directory 'src/emacs' and all files and directories under it, and print the names of the other files found, do something like this:
find . -path ./src/emacs -prune -o -print
Note that the pattern match test applies to the whole file name, starting from one of the start points named on the command line. It would only make sense to use an absolute path name here if the relevant start point is also an absolute path. This means that this command will never match anything:
lol
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, hantaowang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |