Skip to content

Use new deployment strategy and version flags for k8s integration migration tests #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2019

Conversation

davidz627
Copy link
Contributor

/kind failing-test

What this PR does / why we need it:
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/323/files
added new flags for the test framework. This PR updates to use those flags for the migration tests.

/assign @msau42 @hantaowang

NONE

@k8s-ci-robot
Copy link
Contributor

@davidz627: GitHub didn't allow me to assign the following users: hantaowang.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/kind failing-test

What this PR does / why we need it:
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/323/files
added new flags for the test framework. This PR updates to use those flags for the migration tests.

/assign @msau42 @hantaowang

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2019
@davidz627 davidz627 force-pushed the fix/migrationTests branch from 58af4ef to 88f2e4e Compare June 28, 2019 21:05
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2019
@hantaowang
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 965ba6a into kubernetes-sigs:master Jun 29, 2019
@davidz627 davidz627 deleted the fix/migrationTests branch July 2, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants