Skip to content

Bump attacher to v1.2.0 to stable and provisioner v1.2.1 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2019
Merged

Bump attacher to v1.2.0 to stable and provisioner v1.2.1 #324

merged 1 commit into from
Jun 26, 2019

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Jun 26, 2019 •
edited
Loading

/kind feature

What this PR does / why we need it:
Pick up changes in v1.2.0 attacher
https://github.com/kubernetes-csi/external-attacher/releases/tag/v1.2.0

Picking up support for inline volume migration and some fixes for backward compatible access modes for migration

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from saad-ali and verult June 26, 2019 18:20
@davidz627
Copy link
Contributor Author

/hold
until new attacher image available

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2019
@msau42
Copy link
Contributor

msau42 commented Jun 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2019
@davidz627
Copy link
Contributor Author

/hold cancel
image available

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2019
@davidz627 davidz627 changed the title Bump attacher to v1.2.0 to stable Bump attacher to v1.2.0 to stable and provisioner v1.2.1 Jun 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 926776e into kubernetes-sigs:master Jun 26, 2019
@davidz627 davidz627 deleted the stable/attacher branch June 26, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@verult verult Awaiting requested review from verult

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidz627 @k8s-ci-robot @msau42