-
Notifications
You must be signed in to change notification settings - Fork 159
Separate test k8s #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate test k8s #323
Conversation
Hi @hantaowang. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
e74e71e
to
f77f651
Compare
8cae4dc
to
be1b8f2
Compare
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, hantaowang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
be1b8f2
to
430f291
Compare
/pony Twilight Sparkle |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Per #319, break up the PR into small ones. This one builds onto #322 and adds the test-version flag. It also separates k8s building and cluster booting, so that you can boot a cluster without having to build k8s. The rules for how flags can be used together is defined here:
Do not merge until after #322 is merged. Then master will be rebased into this PR.