Skip to content

Add support for Resize (Expand Volume) on the driver #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2019
Merged

Add support for Resize (Expand Volume) on the driver #317

merged 3 commits into from
Jul 3, 2019

Conversation

davidz627
Copy link
Contributor

/kind feature

Fixes #227

/assign @msau42 @saad-ali
/cc @gnufied

Adds support for ControllerExpandVolume and NodeExpandVolume

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

@davidz627: GitHub didn't allow me to request PR reviews from the following users: gnufied.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/kind feature

Fixes #227

/assign @msau42 @saad-ali
/cc @gnufied

Adds support for ControllerExpandVolume and NodeExpandVolume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2019
msau42
msau42 reviewed Jun 24, 2019
View reviewed changes
@davidz627
Copy link
Contributor Author

@msau42 addressed your comments

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2019
msau42
msau42 reviewed Jun 25, 2019
View reviewed changes
gnufied
gnufied reviewed Jun 25, 2019
View reviewed changes
Copy link

@gnufied gnufied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good

@davidz627 davidz627 force-pushed the feature/resize branch 2 times, most recently from 23a2a74 to dd9f565 Compare June 25, 2019 21:34
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 25, 2019
@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

1 similar comment
@davidz627
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@davidz627 davidz627 force-pushed the feature/resize branch 3 times, most recently from 0d6e4b9 to e5fa733 Compare June 28, 2019 20:26
@davidz627
Copy link
Contributor Author

@gnufied @msau42
made requested changes

msau42
msau42 reviewed Jun 29, 2019
View reviewed changes
pkg/gce-pd-csi-driver/node.go Outdated
if err != nil {
return nil, status.Error(codes.Internal, fmt.Sprintf("ControllerExpandVolume error when getting size of block volume at path %s: %v", devicePath, err))
}
if gotBlockSizeBytes != reqBytes {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be got >= req? I believe GCE rounds up (?) to the nearest Gb?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we need to check disk size at all here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think im going to continue to verify disk size but just check for got >= req. Just as a quick sanity check. It's not super necessary but might catch errors if for some reason the disk is not resized properly

@davidz627 davidz627 force-pushed the feature/resize branch 2 times, most recently from 060d355 to acef10c Compare July 2, 2019 23:21
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 3, 2019 •
edited
Loading

@davidz627: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-gcp-compute-persistent-disk-csi-driver-verify c29e6d1 link /test pull-gcp-compute-persistent-disk-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msau42
Copy link
Contributor

msau42 commented Jul 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit e59f47e into kubernetes-sigs:master Jul 3, 2019
@davidz627 davidz627 deleted the feature/resize branch July 3, 2019 21:53
hantaowang pushed a commit to hantaowang/gcp-compute-persistent-disk-csi-driver that referenced this pull request Jul 4, 2019
Revert "Merge pull request kubernetes-sigs#317 from davidz627/feature…
b12e2f1 
…/resize"

This reverts commit e59f47e, reversing
changes made to 41f103f.
hantaowang pushed a commit to hantaowang/gcp-compute-persistent-disk-csi-driver that referenced this pull request Jul 4, 2019
Revert "Merge pull request kubernetes-sigs#317 from davidz627/feature…
0c1c9d2 
…/resize"

This reverts commit e59f47e, reversing
changes made to 41f103f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@msau42 msau42 msau42 left review comments

Assignees

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support expand volume
5 participants
@davidz627 @k8s-ci-robot @msau42 @gnufied @saad-ali