Updated Kubernetes dependency to v1.15 and fixed all dep errors #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
approved
msau42
reviewed
Jun 20, 2019
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| branch = "release-1.11" | ||
| version = "kubernetes-1.15.0-alpha.3" |
There was a problem hiding this comment.
Is there an official 1.15 tag we can use now
There was a problem hiding this comment.
yeah looks like they were just published
davidz627
force-pushed
the
fix/imports
branch
4 times, most recently
from
b70cf76 to
21a7e9d
Compare
|
@msau42 I believe I've resolved all remaining dep issues (mainly around the |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Gopkg.tomlfile is now sorted and commented and all makes sense./assign @msau42