Remove cross validation of access modes, multiple access modes can be specified that represent all the capabilities of the volume #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
davidz627
force-pushed
the
fix/validateAccessModes
branch
from
6d11056 to
cbb0e03
Compare
k8s-ci-robot
added
size/M
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Should we add an e2e test with multiple access modes? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@msau42 there are now unit tests with multiple access modes. K8s has e2e tests with multiple access modes that are not in the external test suites (yet, I assume) |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Do you think it is a valuable test case to add to the k8s external test suite? |
… specified that represent all the capabilities of the volume
davidz627
force-pushed
the
fix/validateAccessModes
branch
from
cbb0e03 to
3d6be58
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @msau42 @saad-ali
Needs to be cherry-picked to release-0.5.0 and new release version to be cut.
Also we should identify why none of the tests specify more than one access mode...
/kind bug