Pull deployment scripting and RBAC rule fixes into v0.5.0 release branch #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update scripts to be compatible with project ids that include the org…
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
msau42
reviewed
Jun 5, 2019
| - apiGroups: [""] | ||
| resources: ["events"] | ||
| verbs: ["list", "watch", "create", "update", "patch"] | ||
| - apiGroups: ["snapshot.storage.k8s.io"] |
There was a problem hiding this comment.
do we want snapshot rules here or only in alpha overlay?
|
This one is for master: #284 |
davidz627
force-pushed
the
feature/updateRBAC
branch
from
6e2ed26 to
a5f3725
Compare
k8s-ci-robot
added
cncf-cla: yes
|
moved snapshot rules to alpha overlay |
…d roles required based on upstream repositories
davidz627
force-pushed
the
feature/updateRBAC
branch
from
a5f3725 to
d1538d7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @msau42 @verult