Add support for raw block devices and enable block device tests on external k8s testing #283
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| glog.V(4).Infof("NodePublishVolume with block volume mode") | ||
|
|
||
| partition := "" | ||
| if part, ok := req.GetVolumeContext()[common.VolumeAttributePartition]; ok { |
There was a problem hiding this comment.
Do we want to support partitions with block? I thought partitions was sort of broken already and we only wanted to keep it for backwards compatibility
There was a problem hiding this comment.
The only broken part is specifying two partitions of the same disk in a pod: kubernetes/kubernetes#57915
Our fs mount supports partitions as much as in-tree supports them (and will continue to have to for migration). If the in-tree block supports partitions we will have to support them for the driver as well
There was a problem hiding this comment.
I'm unsure if it does. We should add test cases if we do...
pkg/gce-pd-csi-driver/node.go
Outdated
| err = ns.Mounter.MakeFile(targetPath) | ||
| if err != nil { | ||
| if removeErr := os.Remove(targetPath); removeErr != nil { | ||
| return nil, status.Error(codes.Internal, fmt.Sprintf("Error removing block file at target path %v: %v", targetPath, removeErr)) |
There was a problem hiding this comment.
do we also want to log the original error?
davidz627
force-pushed
the
feature/block
branch
6 times, most recently
from
2625ad4 to
5c9666c
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
@msau42 had to rebase PTAL |
…ternal k8s testing
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
release-note
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
Fixes: #64
Add support for Raw Block devices.
Enable the external driver tests for block.
/assign @msau42