Skip to content

E2E Testing Framework Changes for PROW Pre-Submits #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2018
Merged

E2E Testing Framework Changes for PROW Pre-Submits #27

merged 2 commits into from
Jun 26, 2018

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Jun 25, 2018 •
edited
Loading

Fixes: #14

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from saad-ali June 25, 2018 22:56
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2018
@msau42
Copy link
Contributor

msau42 commented Jun 25, 2018

You have the name change commit included here too

@davidz627
Copy link
Contributor Author

@msau42 I'm just trying to layer commits until I get CI to pass right now. Not sure exactly what is borking it

@davidz627
Copy link
Contributor Author

/retest

1 similar comment
@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2018
@davidz627
Copy link
Contributor Author

/retest

1 similar comment
@davidz627
Copy link
Contributor Author

/retest

@davidz627 davidz627 force-pushed the fix/projectImage branch 10 times, most recently from 6e14ba0 to 525ade5 Compare June 26, 2018 22:51
@davidz627
Copy link
Contributor Author

/retest

@davidz627 davidz627 force-pushed the fix/projectImage branch 2 times, most recently from ee2a8b3 to baa9465 Compare June 26, 2018 23:22
@davidz627 davidz627 changed the title Image change to Public Debian 9 E2E Testing Framework Changes for PROW Pre-Submits Jun 26, 2018
@davidz627 davidz627 mentioned this pull request Jun 26, 2018
Closed
@davidz627
Copy link
Contributor Author

/assign @msau42
It isn't pretty right now but pre-submits are running both CSI Sanity and the E2E Tests!!
I will submit PR later this week cleaning it up a little.
New issue tracking cleanup #29

@msau42
Copy link
Contributor

msau42 commented Jun 26, 2018

/lgtm
Woot :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 64591de into kubernetes-sigs:master Jun 26, 2018
@davidz627 davidz627 deleted the fix/projectImage branch June 26, 2018 23:46
This was referenced Jun 26, 2018
Closed
Closed
jsafrane pushed a commit to jsafrane/gcp-compute-persistent-disk-csi-driver that referenced this pull request Sep 29, 2022
@openshift-merge-robot
Merge pull request kubernetes-sigs#27 from jsafrane/rebase-v1.7.3
42ec3d2 
STOR-862: Rebase to v1.7.3 for OCP 4.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidz627 @k8s-ci-robot @msau42