Skip to content

Use K8s external-storage test framework #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2019
Merged

Use K8s external-storage test framework #249

merged 1 commit into from
Apr 29, 2019

Conversation

msau42
Copy link
Contributor

@msau42 msau42 commented Apr 20, 2019 •
edited
Loading

Fixes #228

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2019
@k8s-ci-robot k8s-ci-robot requested review from jingxu97 and verult April 20, 2019 02:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2019
@msau42 msau42 changed the title Use K8s external-storage test framework WIP: Use K8s external-storage test framework Apr 22, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2019
@msau42 msau42 force-pushed the use-external-tests branch 5 times, most recently from 82de520 to ca37ad6 Compare April 25, 2019 23:05
@msau42 msau42 force-pushed the use-external-tests branch from ca37ad6 to ee485c4 Compare April 26, 2019 00:38
@msau42
Copy link
Contributor Author

msau42 commented Apr 27, 2019

/assign @davidz627

@msau42 msau42 changed the title WIP: Use K8s external-storage test framework Use K8s external-storage test framework Apr 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2019
@davidz627
Copy link
Contributor

/lgtm
/approve
when this merges we can remove gcePDExternalCSIDriver from k8s/k8s!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42 msau42 mentioned this pull request Apr 29, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit 1d8de6e into kubernetes-sigs:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@verult verult Awaiting requested review from verult

Assignees

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate k8s integration test suite to new parameterized suite
3 participants
@msau42 @davidz627 @k8s-ci-robot