Skip to content

Enable topology #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2019
Merged

Enable topology #243

merged 2 commits into from
Apr 23, 2019

Conversation

msau42
Copy link
Contributor

@msau42 msau42 commented Apr 4, 2019

Depends on #242

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2019
@msau42 msau42 force-pushed the enable-topology branch 2 times, most recently from 74da8d8 to 5fd8c54 Compare April 13, 2019 03:08
@msau42 msau42 mentioned this pull request Apr 16, 2019
Merged
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2019
@davidz627
Copy link
Contributor

@msau42 is this ready for review?

@msau42
Copy link
Contributor Author

msau42 commented Apr 19, 2019

Yes this is ready.

I have a hold here so we can decide if we want to cut a new driver before adding topology since it will require min K8s 1.14

@msau42
Copy link
Contributor Author

msau42 commented Apr 22, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2019
@msau42
Copy link
Contributor Author

msau42 commented Apr 22, 2019

We can always backport things to older releases if we want something for < 1.14

@msau42
Copy link
Contributor Author

msau42 commented Apr 22, 2019

We should cut this as 0.5.x since it requires K8s version bump

davidz627
davidz627 reviewed Apr 22, 2019
View reviewed changes
deploy/kubernetes/overlays/stable/kustomization.yaml Outdated
@@ -2,6 +2,8 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
bases:
- ../../base
patches:
- controller_disable_topology.yaml
Copy link
Contributor

@davidz627 davidz627 Apr 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that all patches are additive to minimize confusion.
The way I think dependencies should work:

base

Let me know what you think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure that works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a new commit

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2019
@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2bb4f15 into kubernetes-sigs:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 davidz627 left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msau42 @k8s-ci-robot @davidz627