Skip to content

Add Labels Override for Gen3 VMs #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sunnylovestiramisu
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Manual cherry-pick for the attach limit override feature, including #2072 and #2092.

To not break customers on PD, we decided to still use the PD attach limit instead of the Hyperdisk one.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add Labels Override for Gen3 VMs

halimsam and others added 30 commits March 4, 2025 23:51
…ot/cherry-pick-1966-to-release-1.17

[release-1.17] Adding additional checks for data cache watcher and reduceVolumeGroup
Updates emicklei/go-restful to v3 via updating kube-openapi.

This was done with
go get -u k8s.io/kube-openapi
go mod tidy
go mod vendor

Change-Id: I86f0793c0c5eca522fa1aaecc54d59c17499b242
…1.17

Update changelog and test image to release-v1.17.1
…ot/cherry-pick-1989-to-release-1.17

[release-1.17] Pass performance parameters when creating regional disks.
…ot/cherry-pick-1993-to-release-1.17

[release-1.17] Fix logic bug while checking available LSSDs for RAIDing for Data Cache
…ot/cherry-pick-1990-to-release-1.17

[release-1.17] Add exponential backoff retries for getting Node from API server logic
…ot/cherry-pick-1910-to-release-1.17

[release-1.17] Add handling for TPC to GetRegionFromZones
…s.Split in case of multiple consecutive spaces.
…ot/cherry-pick-2006-to-release-1.17

[release-1.17] Use strings.Fields for whitespace splitting to fix issues with strings.Split in case of  multiple consecutive spaces
…ot/cherry-pick-2007-to-release-1.17

[release-1.17] Fix units for cache size while calculating chunk size for LVM
…ot/cherry-pick-2010-to-release-1.17

[release-1.17] Map insufficient free space error during cache creating to InvalidArgument error
…ot/cherry-pick-2019-to-release-1.17

[release-1.17] Add Attach Limit for Hyperdisk + Gen4 VMs
…ot/cherry-pick-2004-to-release-1.17

[release-1.17] Add pageToken response check to ListSnapshots gRPC API
…ot/cherry-pick-2028-to-release-1.17

[release-1.17] fix outdated metadata error in watcher
…me creation. This enables empty ROX multi-zone PVCs to be created, to allow for static hydration of disks
Sneha-at and others added 13 commits April 3, 2025 14:56
…y-pick-of-#2037-upstream-release-1.17

[release-1.17]Automated cherry pick of kubernetes-sigs#2037: update cache logic to calculate chunk size based on total
…ot/cherry-pick-1975-to-release-1.17

[release-1.17] Relax volumeContentSource restriction for ROX multi-zone dynamic volume creation
Reserve 1 attachment for the root / OS disk when reporting nr. of
attachable hyperdisks.
…ot/cherry-pick-2057-to-release-1.17

[release-1.17] Fix hyperdisk attach limits
…eFix

Fix Hyperdisk Resize That Requires Iops/Throughput Adjustment

(cherry picked from commit 2858b94)
…se-1.17

Fix Hyperdisk Resize That Requires Iops/Throughput Adjustment
…move-logs

Remove no-op Watcher logs for GKE Data Cache in 1.17 release branch
…ot/cherry-pick-2096-to-release-1.17

[release-1.17] Fix Gen4 Custom VM Cases
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot requested a review from pwschuurman June 5, 2025 20:44
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot requested a review from saikat-royc June 5, 2025 20:44
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 5, 2025
…hLimit

Adjust Attach Limits for Gen3 Machines + Add Labels Override
…hLimit

Using Default PD Attach Limit for Gen3 Machines
@k8s-ci-robot
Copy link
Contributor

@sunnylovestiramisu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022 16a57d4 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022
pull-gcp-compute-persistent-disk-csi-driver-unit 16a57d4 link true /test pull-gcp-compute-persistent-disk-csi-driver-unit
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 16a57d4 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019
pull-gcp-compute-persistent-disk-csi-driver-sanity 16a57d4 link true /test pull-gcp-compute-persistent-disk-csi-driver-sanity
pull-gcp-compute-persistent-disk-csi-driver-verify 16a57d4 link true /test pull-gcp-compute-persistent-disk-csi-driver-verify
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 16a57d4 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
pull-gcp-compute-persistent-disk-csi-driver-e2e 16a57d4 link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sunnylovestiramisu
Copy link
Contributor Author

wrong branch
/close

@k8s-ci-robot
Copy link
Contributor

@sunnylovestiramisu: Closed this PR.

In response to this:

wrong branch
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.