Fix Gen4 Custom VM Cases #2096
Fix Gen4 Custom VM Cases #2096
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
|
/retest |
sunnylovestiramisu
force-pushed
the
attachLimit
branch
2 times, most recently
from
d3926f2 to
ca86c1d
Compare
sunnylovestiramisu
force-pushed
the
attachLimit
branch
from
ca86c1d to
b2995ba
Compare
k8s-ci-robot
added
size/M
|
/test pull-gcp-compute-persistent-disk-csi-driver-unit |
sunnylovestiramisu
force-pushed
the
attachLimit
branch
2 times, most recently
from
9a30c6c to
b7870b9
Compare
pkg/gce-pd-csi-driver/node.go
Outdated
| @@ -657,6 +657,8 @@ func (ns *GCENodeServer) NodeGetInfo(ctx context.Context, req *csi.NodeGetInfoRe | |||
| volumeLimits, err := ns.GetVolumeLimits(ctx) | |||
| if err != nil { | |||
| klog.Errorf("GetVolumeLimits failed: %v", err.Error()) | |||
There was a problem hiding this comment.
add to the message that the error is ignored. This will help future generations looking at logs
sunnylovestiramisu
force-pushed
the
attachLimit
branch
from
b7870b9 to
10bb90a
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.18 |
|
@sunnylovestiramisu: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sunnylovestiramisu: new pull request created: #2098 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.17 |
|
@sunnylovestiramisu: new pull request created: #2099 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.14 |
|
@sunnylovestiramisu: new pull request created: #2100 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Custom VM naming does not follow the current string handling, it returns an error in NodeGetInfo and breaks customers.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: