Skip to content

GKE-MT Support for PDCSI #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

GKE-MT Support for PDCSI #2081

merged 4 commits into from
Jun 12, 2025
+36,980 −37

Conversation

cemakd
Copy link
Contributor

@cemakd cemakd commented May 7, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds capability to the GCE cloud provider for PDCSI to be GKE-MT aware.

Which issue(s) this PR fixes:
N/A
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
n/a

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from leiyiz May 7, 2025 21:24
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tyuchn May 7, 2025 21:24
@k8s-ci-robot
Copy link
Contributor

Hi @cemakd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 7, 2025
cemakd added 3 commits June 3, 2025 23:50
@cemakd
[WIP] GKE-MT support for PDCSI
70b4dc1 
[WIP] Refactor token source code into the token_source.go file

Cleaning up a few logs
@cemakd
Debugging logs
98d67be
@cemakd
Refactor to move tenant related logic into tennacy package
76e7c9b
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2025
@mattcary
Copy link
Contributor

mattcary commented Jun 4, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
@cemakd cemakd marked this pull request as ready for review June 4, 2025 17:50
@k8s-ci-robot k8s-ci-robot requested a review from julianKatz June 4, 2025 17:50
@cemakd cemakd changed the title [WIP] GKE-MT Support for PDCSI GKE-MT Support for PDCSI Jun 4, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2025
@mattcary
Copy link
Contributor

mattcary commented Jun 4, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-unit

mattcary
mattcary reviewed Jun 4, 2025
View reviewed changes
@cemakd
Copy link
Contributor Author

cemakd commented Jun 9, 2025

/retest

@mattcary
Copy link
Contributor

mattcary commented Jun 9, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cemakd, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@cemakd
Copy link
Contributor Author

cemakd commented Jun 11, 2025

/retest

@cemakd
go.mod changes
03c842b 
Fix failing unit tests due to missing kubeconfig in unit test environment

Remove commented out debug statements and fix list volume for non-MT clsuters

Fix list instances call by adding back the main project call
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@cemakd
Copy link
Contributor Author

cemakd commented Jun 12, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 12, 2025 •
edited
Loading

@cemakd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022 03c842b link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 03c842b link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit f167d66 into kubernetes-sigs:master Jun 12, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary mattcary left review comments

@leiyiz leiyiz Awaiting requested review from leiyiz

@tyuchn tyuchn Awaiting requested review from tyuchn

@julianKatz julianKatz Awaiting requested review from julianKatz

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemakd @k8s-ci-robot @mattcary