-
Notifications
You must be signed in to change notification settings - Fork 159
Use strings.Fields for whitespace splitting to fix issues with strings.Split in case of multiple consecutive spaces #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use strings.Fields for whitespace splitting to fix issues with strings.Split in case of multiple consecutive spaces #2006
Conversation
3c6d11a
to
c384662
Compare
…s.Split in case of multiple consecutive spaces.
c384662
to
fd0122c
Compare
@hungnguyen243: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hungnguyen243, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.17 |
@hungnguyen243: new pull request created: #2008 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Use strings.Fields for whitespace splitting to fix issues with strings.Split in case of multiple consecutive spaces
What type of PR is this?
/kind bug
What this PR does / why we need it:
strings.Split(s, " ") hides potential parsing bugs in case we have multiple spaces, so we're replacing it with strings.Fields(s) (https://pkg.go.dev/strings#Fields), which splits based one or more consecutive spaces.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: