Make integration tests support windows 2022 #1999
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
Can we submit the test-infra change first for 2022 and then enable the tests to run in this PR? |
|
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -35,6 +36,11 @@ if [ "$use_kubetest2" = true ]; then | |||
| go install sigs.k8s.io/kubetest2/kubetest2-tester-ginkgo@${kt2_version} | |||
| fi | |||
|
|
|||
| if [ "$windows_distribution" != "win2019" -a "$windows_distribution" != "win2022"] { | |||
| print "Invalid windows distribution $windows_distribution provided. Exiting." | |||
There was a problem hiding this comment.
if [ "$windows_distribution" != "win2019" -a "$windows_distribution" != "win2022"]
print "Invalid windows distribution $windows_distribution provided. Exiting."
exit 1
fi
?
tonyzhc
force-pushed
the
windows-2022
branch
2 times, most recently
from
3a439e4 to
2b4e84d
Compare
|
/retest |
tonyzhc
force-pushed
the
windows-2022
branch
4 times, most recently
from
c90e8ef to
fc5dd39
Compare
|
@sunnylovestiramisu ok, this PR produced passing results and is ready for review. |
|
/retest |
|
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 failed with [It] External Storage [Driver: csi-gcepd-sc-windows--pd-volumesnapshotclass] [Testpattern: Pre-provisioned Snapshot (retain policy)] snapshottable [Feature:VolumeSnapshotDataSource] volume snapshot controller should check snapshot fields, check restore correctly works after modifying source data, check deletion (persistent) which is a flaky test. |
deploy/kubernetes/wait-for-driver.sh
Outdated
| @@ -24,12 +24,6 @@ while [[ -n "${1-}" ]]; do | |||
| esac | |||
| done | |||
|
|
|||
| kubectl wait \ | |||
There was a problem hiding this comment.
Why we do not need to check driver readiness anymore?
There was a problem hiding this comment.
Oops, this was a dev change to test things out. Added back.
|
/retest |
|
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sunnylovestiramisu, tonyzhc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
What this PR does / why we need it:
We need to support Windows 2022 nodes as well. This PR also makes the integration tests perform build for its platform only, instead of a multi-arch build. This will speed up the time to run the test.
This test will subsequently be enabled to run in CI in https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/gcp-compute-persistent-disk-csi-driver-windows.yaml. We will only need to change the WINDOWS_NODE_OS_DISTRIBUTION env var.
Which issue(s) this PR fixes:
Fixes b/404487793.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: