-
Notifications
You must be signed in to change notification settings - Fork 159
Update change log and docs for release v1.17.1 to master #1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, Sneha-at The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/easycla |
1 similar comment
/easycla |
c2e6bcc
to
636b746
Compare
/lgtm |
/hold
Oh! you're right, it does need to be kept in sync. pdImagePlaceholder should be changed to use the registery prefix. |
acf04ee
to
ef7d0b0
Compare
test/k8s-integration/main.go
Outdated
@@ -84,7 +84,7 @@ var ( | |||
) | |||
|
|||
const ( | |||
pdImagePlaceholder = "gke.gcr.io/gcp-compute-persistent-disk-csi-driver" | |||
pdImagePlaceholder = "registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattcary Is this the image path you were referring to? Do we also need a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup that's it exactly
/cancel hold |
/hold cancel |
/hold Actually it looks like the image tag didn't get correctly replaced. Search the k8s integration test logs for kind: Daemonset and you'll see the following
But the image should look something like
|
/retest-required |
@mattcary I don't think there's any path update needed fro the integration test, I see the driver is built correctly
Full config for controller from latest integration test run
|
@Sneha-at: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/hold cancel |
What type of PR is this?
What this PR does / why we need it:
Updates the testing image to latest tag for new release and adds changelog for the new release release-1.17 branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: