Skip to content

Update change log and docs for release v1.17.1 to master #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented Mar 5, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Updates the testing image to latest tag for new release and adds changelog for the new release release-1.17 branch.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 5, 2025
Copy link

linux-foundation-easycla bot commented Mar 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Sneha-at / name: Sneha-at (efb4c18)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2025
@Sneha-at Sneha-at changed the title Update change log and docs for release v1.17.1 Update change log and docs for release v1.17.1 to master Mar 5, 2025
@mattcary
Copy link
Contributor

mattcary commented Mar 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@mattcary
Copy link
Contributor

mattcary commented Mar 5, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@Sneha-at Sneha-at marked this pull request as draft March 5, 2025 22:30
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2025
@Sneha-at Sneha-at marked this pull request as ready for review March 5, 2025 22:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2025
@Sneha-at
Copy link
Contributor Author

Sneha-at commented Mar 6, 2025

/easycla

1 similar comment
@Sneha-at
Copy link
Contributor Author

Sneha-at commented Mar 6, 2025

/easycla

@Sneha-at Sneha-at force-pushed the update-master branch 2 times, most recently from c2e6bcc to 636b746 Compare March 6, 2025 20:41
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2025
@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2025
@mattcary
Copy link
Contributor

mattcary commented Mar 6, 2025

/hold

But we do not need to change it manually anymore in test/k8s-integration/main.go? I think this comment session needs to be updated.

Oh! you're right, it does need to be kept in sync.

pdImagePlaceholder should be changed to use the registery prefix.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 6, 2025
@Sneha-at Sneha-at force-pushed the update-master branch 2 times, most recently from acf04ee to ef7d0b0 Compare March 6, 2025 22:30
@@ -84,7 +84,7 @@ var (
)

const (
pdImagePlaceholder = "gke.gcr.io/gcp-compute-persistent-disk-csi-driver"
pdImagePlaceholder = "registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattcary Is this the image path you were referring to? Do we also need a version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that's it exactly

@mattcary
Copy link
Contributor

mattcary commented Mar 6, 2025

/cancel hold
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2025
@mattcary
Copy link
Contributor

mattcary commented Mar 6, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2025
@mattcary
Copy link
Contributor

mattcary commented Mar 7, 2025

/hold

Actually it looks like the image tag didn't get correctly replaced. Search the k8s integration test logs for kind: Daemonset and you'll see the following


apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: csi-gce-pd-node
  namespace: gce-pd-csi-driver
spec:
  selector:
    matchLabels:
      app: gcp-compute-persistent-disk-csi-driver
  template:
    metadata:
      labels:
        app: gcp-compute-persistent-disk-csi-driver
    spec:
      containers:
      - args:
        - --v=5
        - --endpoint=unix:/csi/csi.sock
        - --run-controller-service=false
        - --enable-data-cache
        - --node-name=$(KUBE_NODE_NAME)
        env:
        - name: KUBE_NODE_NAME
          valueFrom:
            fieldRef:
              fieldPath: spec.nodeName
        image: registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:v1.17.2
        imagePullPolicy: Always
        name: gce-pd-driver
        securityContext:
          privileged: true
        volumeMounts:
        - mountPath: /var/lib/kubelet
          mountPropagation: Bidirectional
          name: kubelet-dir
        - mountPath: /csi
          name: plugin-dir
        - mountPath: /dev
          name: device-dir
        - mountPath: /etc/udev
          name: udev-rules-etc
        - mountPath: /lib/udev
          name: udev-rules-lib
        - mountPath: /run/udev
          name: udev-socket
        - mountPath: /sys
          name: sys
        - mountPath: /lib/modules
        - ...

But the image should look something like

        image: gcr.io/k8s-infra-e2e-boskos-016/gcp-persistent-disk-csi-driver:f7544c99-5420-4f2f-bac1-88214a737d67

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 7, 2025
@Sneha-at
Copy link
Contributor Author

/retest-required

@Sneha-at
Copy link
Contributor Author

Sneha-at commented Mar 13, 2025

@mattcary I don't think there's any path update needed fro the integration test, I see the driver is built correctly

        image: gcr.io/k8s-infra-e2e-boskos-068/gcp-persistent-disk-csi-driver:0fe1554e-94d5-42a9-9fe2-8943c28cc946

Full config for controller from latest integration test run

apiVersion: apps/v1
kind: Deployment
metadata:
  name: csi-gce-pd-controller
  namespace: gce-pd-csi-driver
spec:
  replicas: 1
  selector:
    matchLabels:
      app: gcp-compute-persistent-disk-csi-driver
  template:
    metadata:
      labels:
        app: gcp-compute-persistent-disk-csi-driver
    spec:
      containers:
      - args:
        - --v=5
        - --endpoint=unix:/csi/csi.sock
        - --supports-dynamic-iops-provisioning=hyperdisk-balanced,hyperdisk-extreme
        - --supports-dynamic-throughput-provisioning=hyperdisk-balanced,hyperdisk-throughput,hyperdisk-ml
        - --enable-data-cache
        - --supports-dynamic-throughput-provisioning=hyperdisk-balanced,hyperdisk-throughput,hyperdisk-ml
        - --supports-dynamic-iops-provisioning=hyperdisk-balanced,hyperdisk-extreme
        command:
        - /gce-pd-csi-driver
        env:
        - name: GOOGLE_APPLICATION_CREDENTIALS
          value: /etc/cloud-sa/cloud-sa.json
        image: gcr.io/k8s-infra-e2e-boskos-068/gcp-persistent-disk-csi-driver:0fe1554e-94d5-42a9-9fe2-8943c28cc946
        imagePullPolicy: Always
        name: gce-pd-driver
        volumeMounts:
        - mountPath: /csi
          name: socket-dir
        - mountPath: /etc/cloud-sa
          name: cloud-sa-volume
          readOnly: true

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 13, 2025
@k8s-ci-robot
Copy link
Contributor

@Sneha-at: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 efb4c18 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@mattcary
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8cadba4 into kubernetes-sigs:master Mar 14, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants