Skip to content

Fix CVE-2022-1996 #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix CVE-2022-1996 #1967

merged 1 commit into from
Mar 5, 2025

Conversation

mattcary
Copy link
Contributor

github.com/emicklei/go-restful needed to be updated, but to v3 which also required updating k8s openapi.

/kind cleanup

Update k8s open-api and emicklei/go-restful for CVE-2022-1996

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2025
@mattcary
Copy link
Contributor Author

mattcary commented Mar 5, 2025

Probems with python3-minimal installing for the the verify container. It reminds me of the buildkit problems we had before, but it runs locally with the same versions. Sigh. Maybe just a flake?

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2025
@mattcary
Copy link
Contributor Author

mattcary commented Mar 5, 2025

/retest

Maybe kubernetes/test-infra#34461 will fix it.

@mattcary
Copy link
Contributor Author

mattcary commented Mar 5, 2025

oops, missed the merge conflict

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2025
github.com/emicklei/go-restful needed to be updated, but to v3 which
also required updating k8s openapi.

Change-Id: I9dc0fad79785450904db38702a4cae077e6dfbca
@mattcary
Copy link
Contributor Author

mattcary commented Mar 5, 2025

/retest

Seems to be flaky in e2e, instances not reachable by ssh.

@k8s-ci-robot
Copy link
Contributor

@mattcary: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 54f9827 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 54f9827 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor Author

mattcary commented Mar 5, 2025

Only snapshot tests failing, force-merging.

@mattcary mattcary merged commit d7c5a23 into kubernetes-sigs:master Mar 5, 2025
5 of 8 checks passed
@mattcary
Copy link
Contributor Author

mattcary commented Mar 5, 2025

/cherry-pick release-1.17

@mattcary mattcary deleted the cve branch March 5, 2025 21:01
@k8s-infra-cherrypick-robot

@mattcary: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of lines (20000)","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"406"}

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mattcary
Copy link
Contributor Author

mattcary commented Mar 5, 2025

/cherry-pick release-1.17

@k8s-infra-cherrypick-robot

@mattcary: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of lines (20000)","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"406"}

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants