-
Notifications
You must be signed in to change notification settings - Fork 162
Update validation logic for Data Cache to distinguish user and non-us… #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validation logic for Data Cache to distinguish user and non-us… #1960
Conversation
Hi @hungnguyen243. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
pkg/gce-pd-csi-driver/node.go
Outdated
if ns.DataCacheEnabledNodePool { | ||
return nil, status.Error(codes.DataLoss, fmt.Sprintf("Error validate configuration for Data Cache: %v", configError.Error())) | ||
} | ||
return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("Data Cache PVC is requested for an incompatible node pool: %v", configError.Error())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The Data Cache PVC is scheduled on an incompatible node pool. Please select a node pool with data cache configured." So the users know what action to take.
…er errors when RAIDing fails
56e6253
to
4dc330e
Compare
/retest-required |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hungnguyen243, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@hungnguyen243: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
…er errors when RAIDing fails
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR updates the pre-setupCaching validation step for Data Cache to distinguish between non-user and user errors (incorrect node pool configuration) to return appropriate error codes, so that we won't have false positives for SLO alerts.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: