-
Notifications
You must be signed in to change notification settings - Fork 161
Introduce metrics for pdcsi node #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce metrics for pdcsi node #1952
Conversation
Welcome @hajiler! |
Hi @hajiler. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
8ffa08d
to
5d0a4bd
Compare
5d0a4bd
to
4cf2e9b
Compare
/assign msau |
@hajiler: GitHub didn't allow me to assign the following users: msau. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign msau |
@tyuchn: GitHub didn't allow me to assign the following users: msau. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @msau42 |
4cf2e9b
to
35019bf
Compare
/retest |
Has this change been end to end tested? For example on a GCE cluster, you can intentionally return an error at the mount step to trigger the emission. |
Yes, the metrics have successfully been emmitted and are visible on monarch: https://screenshot.googleplex.com/8QfU5iD7cBL8mAS |
4a704bb
to
49faef1
Compare
For other reviewers if you want them to take a look as well |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hajiler, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
26c42da
to
d7e7c4f
Compare
d7e7c4f
to
9e68dea
Compare
/lgtm |
@hajiler: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
/remove-hold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds metrics capability for the PDCSI node server. Metrics enable us to define SLO/Alerts for the node server. This PR specifically adds a metric for mount errors.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: