-
Notifications
You must be signed in to change notification settings - Fork 159
Return DataLoss error status for any Data Cache related code in NodeStageVolume & NodeUnstageVolume. #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NodeUnstageVolume.
Hi @halimsam. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: halimsam, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Return DataLoss error status for any Data Cache related code in NodeStageVolume & NodeUnstageVolume.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is to temporarily mark all Data Cache failures as DataLoss to be able to isolate and detect failures correlating to DataLoss. We use DataLoss since it is an unused status code during the node staging operations.
We temporarily need this for driver SLO implementation for Data Cache feature.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: