Skip to content

Copy kubernetes test binaries to _rundir, instead of _artifacts when running integration test on k8s master branch #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Copy kubernetes test binaries to _rundir, instead of _artifacts when running integration test on k8s master branch #1927

merged 1 commit into from
Feb 12, 2025

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Feb 11, 2025 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: The OSS Prow testgrid is currently failing, due to kubectl and other binaries not being found by ginkgo. This was a result of #1911 which updated the kubetest2 version. In order to fix, the test binaries need to be copied to _rundir/$KUBETEST2_RUN_ID.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2025
@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from f93a8bd to 2ab7f39 Compare February 11, 2025 23:34
@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from 2ab7f39 to 00899e3 Compare February 11, 2025 23:39
@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025
@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from 00899e3 to e8fff70 Compare February 11, 2025 23:59
@pwschuurman
Copy link
Contributor Author

/retest

@amacaskill
Copy link
Member

/test pull-gcp-compute-persistent-disk-csi-driver-unit

@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from e8fff70 to 79cfbea Compare February 12, 2025 01:23
@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from 79cfbea to 4af007f Compare February 12, 2025 16:47
@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from 4af007f to 44406e4 Compare February 12, 2025 18:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2025
@pwschuurman pwschuurman changed the title Use --use-binaries-from-path instead of --use-built-binaries when building k8s from master branch Copy kubernetes test binaries to _rundir, instead of _artifacts when running integration test on k8s master branch Feb 12, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 12, 2025
@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from 44406e4 to 0ed5295 Compare February 12, 2025 19:09
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2025
@pwschuurman pwschuurman marked this pull request as ready for review February 12, 2025 19:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@pwschuurman
Copy link
Contributor Author

/assign @amacaskill

@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from 0ed5295 to 910e70b Compare February 12, 2025 19:20
@pwschuurman
Copy kubernetes test binaries to _rundir, instead of _artifacts when …
9a650b1 
…running integration test on k8s master branch
@pwschuurman pwschuurman force-pushed the fix-prow-oss-tests-kubetest2-upgrade branch from 910e70b to 9a650b1 Compare February 12, 2025 19:21
@amacaskill
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@pwschuurman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 9a650b1 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pwschuurman
Copy link
Contributor Author

All integration tests passing, except for a snapshot test

: [It] External Storage [Driver: csi-gcepd-sc-balanced--pd-volumesnapshotclass--no-vac] [Testpattern: Dynamic Snapshot (retain policy)] snapshottable [Feature:VolumeSnapshotDataSource] volume snapshot controller should check snapshot fields, check restore correctly works after modifying source data, check deletion (persistent)

Submitting.

@pwschuurman pwschuurman merged commit c14dddb into kubernetes-sigs:master Feb 12, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill amacaskill left review comments

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@tyuchn tyuchn Awaiting requested review from tyuchn

@leiyiz leiyiz Awaiting requested review from leiyiz

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@amacaskill amacaskill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwschuurman @k8s-ci-robot @amacaskill