Skip to content

Don't overwrite libc in distroless debian base image #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

pwschuurman
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
In our Dockerfile, we copy over some libraries from gke.gcr.io/debian-base:bookworm- to a gcr.io/distroless/base-debian12 base. Currently this overwrites libc.so.6, which already exists in gcr.io/distroless/base-debian12. This can lead to ABI incompatibilities between ld-linux (which is in base-debian) and the overwritten libc library. At the moment the ARM64 Docker image is broken when running applications that depend on libc. The following error can be seen:

docker run --entrypoint /bin/bash -it  bd99abeb3efc --
/bin/bash: error while loading shared libraries: __kernel_gettimeofday: invalid mode for dlopen(): Invalid argument

Which issue(s) this PR fixes:

Fixes #1882

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix shared library loading runtime error

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2024
@pwschuurman
Copy link
Contributor Author

/assign @saikat-royc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pwschuurman,saikat-royc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saikat-royc
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 486a336 into kubernetes-sigs:master Dec 7, 2024
7 checks passed
@pwschuurman
Copy link
Contributor Author

/cherrypick release-1.15

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1884

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pwschuurman
Copy link
Contributor Author

/cherrypick release-1.14

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1885

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pwschuurman
Copy link
Contributor Author

/cherrypick release-1.14-experimental

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1907

In response to this:

/cherrypick release-1.14-experimental

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM64 Image is broken for binaries that require libc
4 participants