Skip to content

Remove make from verify-all in order to reduce presubmit flakes #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

mattcary
Copy link
Contributor

/kind cleanup
Does this PR introduce a user-facing change?:

None

/assign @amacaskill

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 27, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tyuchn November 27, 2024 19:28
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2024
@pwschuurman
Copy link
Contributor

@mattcary Do you have an example of a verify presubmit flake where make is failing?

From what I've seen the verify presubmit started failing ~2 weeks ago, and times out running the verify-docker-deps command (running on ARM architecture with QEMU). I think #1878 should fix this problem.

@mattcary
Copy link
Contributor Author

@mattcary Do you have an example of a verify presubmit flake where make is failing?

From what I've seen the verify presubmit started failing ~2 weeks ago, and times out running the verify-docker-deps command (running on ARM architecture with QEMU). I think #1878 should fix this problem.

verify-docker-deps is run during the docker bulid which is run as part of the make?

#1878 seems like a good idea, so we should do it too, but since we also build as part of the e2e I'm not sure what the value of running make as part of the verify is.

Having verify focus on the go code seems like a nice understandable and contained step to do. Fiddling with the build process seems like a different thing.

@pwschuurman
Copy link
Contributor

Having verify focus on the go code seems like a nice understandable and contained step to do. Fiddling with the build process seems like a different thing.

Gotcha, agreed. Yeah, I think it's reasonable to remove.

@pwschuurman
Copy link
Contributor

/approve
/lgtm

@mattcary
Copy link
Contributor Author

Hmm, although with #1878 we will no longer verify dependencies as part of presubmit. That's a bug.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattcary,pwschuurman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattcary
Copy link
Contributor Author

Ah, so actually I'm timing out in the verify docker deps which also runs make. So even more reason not to run make again?

@mattcary
Copy link
Contributor Author

I picked up Peter's fix and will retest.

/retest

@k8s-ci-robot k8s-ci-robot merged commit d8c777e into kubernetes-sigs:master Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants