-
Notifications
You must be signed in to change notification settings - Fork 159
Remove make from verify-all in order to reduce presubmit flakes #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
verify-docker-deps is run during the docker bulid which is run as part of the make? #1878 seems like a good idea, so we should do it too, but since we also build as part of the e2e I'm not sure what the value of running make as part of the verify is. Having verify focus on the go code seems like a nice understandable and contained step to do. Fiddling with the build process seems like a different thing. |
Gotcha, agreed. Yeah, I think it's reasonable to remove. |
/approve |
Hmm, although with #1878 we will no longer verify dependencies as part of presubmit. That's a bug. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ah, so actually I'm timing out in the verify docker deps which also runs make. So even more reason not to run make again? |
I picked up Peter's fix and will retest. /retest |
/kind cleanup
Does this PR introduce a user-facing change?:
/assign @amacaskill