Skip to content

Adding missing libgpg-error.so.0 required by nvme-cli #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Jun 25, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The command /usr/bin/nvme requires this shared library. This is used to validate nvme device symlinks. This library is required in Bookworm (after we migrated from Bullseye in #1694)

Validated by running ./hack/verify_docker_deps.h

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes NVMe support in NodeStage and NodePublish

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@pwschuurman
Copy link
Contributor Author

/assign @Sneha-at

@Sneha-at
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ba11f6 into kubernetes-sigs:master Jun 25, 2024
7 checks passed
@pwschuurman
Copy link
Contributor Author

/cherry-pick release-1.14

@pwschuurman
Copy link
Contributor Author

/cherry-pick release-1.13

@pwschuurman
Copy link
Contributor Author

/cherry-pick release-1.12

@pwschuurman
Copy link
Contributor Author

/cherry-pick release-1.11

@pwschuurman
Copy link
Contributor Author

/cherry-pick release-1.10

@pwschuurman
Copy link
Contributor Author

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1765

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1766

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1767

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1768

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1769

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1770

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants