Skip to content

prune changelog for 1.14 #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

pwschuurman
Copy link
Contributor

/kind documentation

/assign @hime

None

@k8s-ci-robot
Copy link
Contributor

@pwschuurman: GitHub didn't allow me to assign the following users: hime.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/kind documentation

/assign @hime

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 13, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@pwschuurman
Copy link
Contributor Author

/cc @hime

@k8s-ci-robot
Copy link
Contributor

@pwschuurman: GitHub didn't allow me to request PR reviews from the following users: hime.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hime
Copy link
Member

hime commented Jun 13, 2024

/lgtm
/approval

@k8s-ci-robot
Copy link
Contributor

@hime: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pwschuurman pwschuurman merged commit 274b781 into kubernetes-sigs:master Jun 13, 2024
1 of 7 checks passed
@pwschuurman
Copy link
Contributor Author

Whoops, wrong branch. Will revert, and apply to release-1.14

pwschuurman added a commit to pwschuurman/gcp-compute-persistent-disk-csi-driver that referenced this pull request Jun 13, 2024
pwschuurman added a commit that referenced this pull request Jun 13, 2024
Add back CHANGELOG, removed in #1745 by mistake
maxkimambo pushed a commit to travisyx/gcp-compute-persistent-disk-csi-driver that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants