Skip to content

Bump CSI Spec version to 0.3.0 and make necessary code update #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2018

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Jun 21, 2018

Fixes: #11

Update CSI Spec to v0.3.0, golang/protobuf to v1.1.0 [transitive dep of CSI Spec], and CSI Test to HEAD [v0.3.0 not cut yet].

Wrote stub functions for new Node and Controller calls.

Implemented barebones NodeGetInfo

/assign @msau42 @saad-ali

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2018
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali June 21, 2018 00:15
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 21, 2018
NodeId: ns.Driver.nodeID,
// TODO: Set MaxVolumesPerNode based on Node Type
// Default of 0 means that CO Decides how many nodes can be published
MaxVolumesPerNode: 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open a tracking issue for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19

@msau42
Copy link
Contributor

msau42 commented Jun 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2018
@davidz627 davidz627 merged commit 50b58c6 into kubernetes-sigs:master Jun 21, 2018
@davidz627 davidz627 deleted the feature/csiv0.3.0 branch June 21, 2018 17:33
jsafrane pushed a commit to jsafrane/gcp-compute-persistent-disk-csi-driver that referenced this pull request Dec 14, 2021
…ncy-openshift-4.10-ose-gcp-pd-csi-driver

Updating ose-gcp-pd-csi-driver images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants