Record original error code to operation_errors metric for temporary errors

[amacaskill]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
When CreateVolume is executed, the csi provisioner expects either "final" or "temporary" errors. If we report final error when disk creation could be ongoing or the disk is already created, then a PVC deletion before successful volume creation could lead to disk leakage as DeleteVolume won't happen.

To prevent disk leakage in PDCSI driver, we changed the error codes returned from GetDisk, InsertDisk, waitForZonalOp / waitForRegionalOp inside of CreateVolume to return the Unavailable / Aborted temporary error code (see PR). The consequence of this most of the interesting errors we get from CreateVolume, all return Unavailable error code, which is filtered out from SLO. This PR reports the original error code (returned by GetDisk, InsertDisk, waitForZonalOp / waitForRegionalOp) to the operation_errors metric, but continues to return the "temporary" errors (Unavailable/Aborted) to the csi provisioner.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Record original error code for temporary errors for kubernetes.io/master/pdcsi/csidriver_operation_errors metric.

[amacaskill]

/assign @leiyiz

[leiyiz]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, leiyiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amacaskill,leiyiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amacaskill]

/hold adding the test case Leiyi suggested.

[amacaskill]

/hold cancel
Added the test case.

[leiyiz]

/lgtm

[amacaskill]

/retest

[amacaskill]

/retest

[amacaskill]

/retest

[amacaskill]

/retest

[leiyiz]

/lgtm

[amacaskill]

/cherry-pick release-1.13

[k8s-infra-cherrypick-robot]

@amacaskill: new pull request created: #1672

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hime]

/cherry-pick release-1.12

[k8s-infra-cherrypick-robot]

@hime: #1664 failed to apply on top of branch "release-1.12":

Applying: Record original error code to operation_errors metric for temporary errors
Using index info to reconstruct a base tree...
M	pkg/common/utils_test.go
M	pkg/gce-cloud-provider/compute/gce-compute.go
M	pkg/gce-pd-csi-driver/controller.go
M	pkg/metrics/metrics.go
M	pkg/metrics/metrics_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/metrics/metrics_test.go
CONFLICT (content): Merge conflict in pkg/metrics/metrics_test.go
Auto-merging pkg/metrics/metrics.go
CONFLICT (content): Merge conflict in pkg/metrics/metrics.go
Auto-merging pkg/gce-pd-csi-driver/controller.go
Auto-merging pkg/gce-cloud-provider/compute/gce-compute.go
Auto-merging pkg/common/utils_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Record original error code to operation_errors metric for temporary errors
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.