-
Notifications
You must be signed in to change notification settings - Fork 159
Add support for checking if a device is being used by a filesystem #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for checking if a device is being used by a filesystem #1658
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bc59621
to
ac499d1
Compare
/assign @mattcary |
/lgtm Good idea to test in e2e. Probably we should have done that for disable device... |
/cherry-pick release-1.13 |
@pwschuurman: #1658 failed to apply on top of branch "release-1.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Cherry pick #1805 |
…658-upstream-release-1.13 Automated cherry pick of #1658: Add support for checking if a device is being used by a
Cherrypick for |
…658-upstream-release-1.12 Automated cherry pick of #1658: Add support for checking if a device is being used by a filesystem
What type of PR is this?
/kind bug
What this PR does / why we need it:
Summary: If a PD block device is still being used by the filesystem (misconfiguration, mount namespace capture), return an error during NodeUnstage.
Currently the PDCSI driver performs an unmount on the globalmount during NodeUnstage, and success signals that ControllerUnpublish (GCE disk detach) can proceed. Normally successful mount is an indicator that there is no other consumer of the device on the OS. There are some sitautions where this may not be true:
/proc/<pid>/ns/mnt
, a private mount point to the block device may exist in a container's mount namespace. Typically this only occurs if there is some other process that has root access to the OS and causes this to occur.Which issue(s) this PR fixes:
Fixes #1657
Special notes for your reviewer:
Does this PR introduce a user-facing change?: