Use precompiled stable release of Kubernetes by default when running integration test #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
pwschuurman
force-pushed
the
run-integration-test-from-stable
branch
from
1878146 to
30580c7
Compare
pwschuurman
force-pushed
the
run-integration-test-from-stable
branch
from
30580c7 to
776f51a
Compare
|
/retest |
|
/assign @saikat-royc @saikat-royc can you take a look? This reinstates some of the behavior of #882 |
|
Looks like this is reducing the test runtime by 20-30 minutes: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/1342/pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration/1691168184113041408/ |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman, saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This adds an option to use a precompiled release of Kubernetes to the integration test, rather than using a github branch and building from source. The build step takes ~30 minutes in the prow integration test, which can lead to long submit times, and flaky tests (due to exceeding the 90 minute timeout).
Does this PR introduce a user-facing change?: