Skip to content

Fix zone specification in HdT tests #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Aug 10, 2023

What type of PR is this?

/kind failing-test

What this PR does / why we need it:
The zone specification was mistakenly added, HdT is available in both the two test zones:

➜  ~ gcloud compute disk-types list --filter="zone:( us-east4-a)" --project xxxxxxx
NAME                  ZONE        VALID_DISK_SIZES
hyperdisk-extreme     us-east4-a  64GB-65536GB
hyperdisk-throughput  us-east4-a  2048GB-32768GB
local-ssd             us-east4-a  375GB-375GB
pd-balanced           us-east4-a  10GB-65536GB
pd-extreme            us-east4-a  500GB-65536GB
pd-ssd                us-east4-a  10GB-65536GB
pd-standard           us-east4-a  10GB-65536GB
➜  ~ gcloud compute disk-types list --filter="zone:( us-east4-c)" --project xxxxxxx
NAME                  ZONE        VALID_DISK_SIZES
hyperdisk-extreme     us-east4-c  64GB-65536GB
hyperdisk-throughput  us-east4-c  2048GB-32768GB
local-ssd             us-east4-c  375GB-375GB
pd-balanced           us-east4-c  10GB-65536GB
pd-extreme            us-east4-c  500GB-65536GB
pd-ssd                us-east4-c  10GB-65536GB
pd-standard           us-east4-c  10GB-65536GB

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix zone specification in HdT tests

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/assign @amacaskill

@amacaskill
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [amacaskill,sunnylovestiramisu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunnylovestiramisu
Copy link
Contributor Author

panic: test timed out after 20m0s

/retest

@k8s-ci-robot k8s-ci-robot merged commit 97b68e6 into kubernetes-sigs:master Aug 11, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot

@sunnylovestiramisu: new pull request created: #1341

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants