Skip to content

Automated cherry pick of #1232: Use errors.As so we can detect wrapped errors, and check for #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

judemars
Copy link
Contributor

@judemars judemars commented Aug 3, 2023

Cherry pick of #1232 on release-1.7.

#1232: Use errors.As so we can detect wrapped errors, and check for

For details on the cherry pick process, see the cherry pick requests page.

Use errors.As so we can detect wrapped errors, and check for existing error codes in CodesForError

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali August 3, 2023 21:32
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 3, 2023
@judemars
Copy link
Contributor Author

judemars commented Aug 3, 2023

/lgtm
/assign @msau42

@k8s-ci-robot
Copy link
Contributor

@judemars: you cannot LGTM your own PR.

In response to this:

/lgtm
/assign @msau42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@judemars
Copy link
Contributor Author

judemars commented Aug 4, 2023

/assign @mattcary

@judemars
Copy link
Contributor Author

judemars commented Aug 4, 2023

/retest

@mattcary
Copy link
Contributor

mattcary commented Aug 4, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: judemars, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 323b56c into kubernetes-sigs:release-1.7 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants