Skip to content

Cherry-pick #1304 to release-1.9 #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2023
Merged

Cherry-pick #1304 to release-1.9 #1308

merged 2 commits into from
Jul 21, 2023

Conversation

mattcary
Copy link
Contributor

Cherry-pick #1304 to release-1.9

/kind bug

Fix resource parsing when the gcp project name ends with alpha, beta or v1

mattcary added 2 commits July 21, 2023 15:13
@mattcary
Replace cleanSelfLink with getResourceId
1c5f571 
Change-Id: I531dc90aa4640afc2d66b5ce57d698a56c7d4564
@mattcary
Cherry-pick kubernetes-sigs#1304 to release-1.9
f2cfc81 
Change-Id: I02a481e7759a502a7ab7117d58357e8139d75971
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2023
@mattcary mattcary mentioned this pull request Jul 21, 2023
Merged
@msau42
Copy link
Contributor

msau42 commented Jul 21, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42
Copy link
Contributor

msau42 commented Jul 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 74d094f into kubernetes-sigs:release-1.9 Jul 21, 2023
@ialidzhikov ialidzhikov mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattcary @msau42 @k8s-ci-robot