Skip to content

Fix provisioned-iops-on-create passing logic #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix provisioned-iops-on-create passing logic #1278

merged 1 commit into from
Jun 27, 2023

Conversation

sunnylovestiramisu
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:
The logic of passing in provisioned-iops-on-create is not at the right func. The tests picked the default value and the verification is passing.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Fix provisioned-iops-on-create passing logic

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/assign @mattcary

@sunnylovestiramisu sunnylovestiramisu force-pushed the bug-fix branch 2 times, most recently from 74e3611 to 4639933 Compare June 27, 2023 15:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2023
@mattcary
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattcary,sunnylovestiramisu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@sunnylovestiramisu sunnylovestiramisu force-pushed the bug-fix branch 3 times, most recently from 8c90ae0 to 5140249 Compare June 27, 2023 16:38
@mattcary
Copy link
Contributor

still lgtm

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@sunnylovestiramisu
Copy link
Contributor Author

sunnylovestiramisu commented Jun 27, 2023 •
edited
Loading

Okay the number failed again, i will try via gcloud cli first before finalize the number.

The validation for pd-extreme seems off, if we do not specify iops, it sets to 100000. However if we set iops, it triggers validations. Also the iops for capacity under 500Gb is not configurable, they will all get 100000. But if we set the diskSize to be 500Gb it will run out of capacity quota for the test project.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 27, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2023
@sunnylovestiramisu sunnylovestiramisu force-pushed the bug-fix branch 3 times, most recently from 1d83ff9 to fcaf28a Compare June 27, 2023 18:00
@sunnylovestiramisu
Copy link
Contributor Author

hack/verify-all.sh succeeded locally, do not know why it is not passing here.

@sunnylovestiramisu
Copy link
Contributor Author

/retest

@sunnylovestiramisu sunnylovestiramisu force-pushed the bug-fix branch 4 times, most recently from 7bc1efe to 0c1938b Compare June 27, 2023 18:35
@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 298e683 into kubernetes-sigs:master Jun 27, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/cherry-pick release-1.10

@sunnylovestiramisu
Copy link
Contributor Author

/cherry-pick release-1.9

@sunnylovestiramisu
Copy link
Contributor Author

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot
Copy link

@sunnylovestiramisu: new pull request created: #1282

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 27, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sunnylovestiramisu: #1278 failed to apply on top of branch "release-1.9":

Applying: Fix provisioned-iops-on-create passing logic
Using index info to reconstruct a base tree...
M	pkg/common/utils_test.go
M	pkg/gce-cloud-provider/compute/gce-compute.go
M	test/e2e/tests/single_zone_e2e_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/tests/single_zone_e2e_test.go
CONFLICT (content): Merge conflict in test/e2e/tests/single_zone_e2e_test.go
Auto-merging pkg/gce-cloud-provider/compute/gce-compute.go
Auto-merging pkg/common/utils_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix provisioned-iops-on-create passing logic
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@sunnylovestiramisu: #1278 failed to apply on top of branch "release-1.8":

Applying: Fix provisioned-iops-on-create passing logic
Using index info to reconstruct a base tree...
M	pkg/common/utils_test.go
M	pkg/gce-cloud-provider/compute/gce-compute.go
M	test/e2e/tests/single_zone_e2e_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/tests/single_zone_e2e_test.go
CONFLICT (content): Merge conflict in test/e2e/tests/single_zone_e2e_test.go
Auto-merging pkg/gce-cloud-provider/compute/gce-compute.go
Auto-merging pkg/common/utils_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix provisioned-iops-on-create passing logic
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 27, 2023
Merged
Merged
@sunnylovestiramisu sunnylovestiramisu deleted the bug-fix branch March 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz Awaiting requested review from leiyiz

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunnylovestiramisu @mattcary @k8s-ci-robot @k8s-infra-cherrypick-robot