Skip to content

Commit fcaf28a

Browse files
sunnylovestiramisusunnylovestiramisu
committed
Fix provisioned-iops-on-create passing logic
1 parent a0c11a7 commit fcaf28a

File tree

3 files changed

+60
-28
lines changed

3 files changed

+60
-28
lines changed

‎pkg/common/utils_test.go

+6
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,12 @@ func TestConvertStringToInt64(t *testing.T) {
597597
expInt64: 10000,
598598
expectError: false,
599599
},
600+
{
601+
desc: "test higher number",
602+
inputStr: "15000",
603+
expInt64: 15000,
604+
expectError: false,
605+
},
600606
{
601607
desc: "round M to number",
602608
inputStr: "1M",

‎pkg/gce-cloud-provider/compute/gce-compute.go

+14-11
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,9 @@ func convertV1DiskToBetaDisk(v1Disk *computev1.Disk, provisionedThroughputOnCrea
419419
ReplicaZones: v1Disk.ReplicaZones,
420420
DiskEncryptionKey: dek,
421421
}
422+
if v1Disk.ProvisionedIops > 0 {
423+
betaDisk.ProvisionedIops = v1Disk.ProvisionedIops
424+
}
422425
if provisionedThroughputOnCreate > 0 {
423426
betaDisk.ProvisionedThroughput = provisionedThroughputOnCreate
424427
}
@@ -449,12 +452,11 @@ func (cloud *CloudProvider) insertRegionalDisk(
449452
}
450453

451454
diskToCreate := &computev1.Disk{
452-
Name: volKey.Name,
453-
SizeGb: common.BytesToGbRoundUp(capBytes),
454-
Description: description,
455-
Type: cloud.GetDiskTypeURI(cloud.project, volKey, params.DiskType),
456-
Labels: params.Labels,
457-
ProvisionedIops: params.ProvisionedIOPSOnCreate,
455+
Name: volKey.Name,
456+
SizeGb: common.BytesToGbRoundUp(capBytes),
457+
Description: description,
458+
Type: cloud.GetDiskTypeURI(cloud.project, volKey, params.DiskType),
459+
Labels: params.Labels,
458460
}
459461
if snapshotID != "" {
460462
_, snapshotType, _, err := common.SnapshotIDToProjectKey(snapshotID)
@@ -562,11 +564,12 @@ func (cloud *CloudProvider) insertZonalDisk(
562564
}
563565

564566
diskToCreate := &computev1.Disk{
565-
Name: volKey.Name,
566-
SizeGb: common.BytesToGbRoundUp(capBytes),
567-
Description: description,
568-
Type: cloud.GetDiskTypeURI(project, volKey, params.DiskType),
569-
Labels: params.Labels,
567+
Name: volKey.Name,
568+
SizeGb: common.BytesToGbRoundUp(capBytes),
569+
Description: description,
570+
Type: cloud.GetDiskTypeURI(project, volKey, params.DiskType),
571+
Labels: params.Labels,
572+
ProvisionedIops: params.ProvisionedIOPSOnCreate,
570573
}
571574

572575
if snapshotID != "" {

‎test/e2e/tests/single_zone_e2e_test.go

+40-17
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,16 @@ import (
4444
const (
4545
testNamePrefix = "gcepd-csi-e2e-"
4646

47-
defaultSizeGb int64 = 5
48-
defaultRepdSizeGb int64 = 200
49-
defaultMwSizeGb int64 = 200
50-
defaultVolumeLimit int64 = 127
51-
readyState = "READY"
52-
standardDiskType = "pd-standard"
53-
extremeDiskType = "pd-extreme"
54-
provisionedIOPSOnCreate = "100000"
55-
provisionedIOPSOnCreateInt = int64(100000)
47+
defaultSizeGb int64 = 5
48+
defaultExtremeSizeGb int64 = 500
49+
defaultRepdSizeGb int64 = 200
50+
defaultMwSizeGb int64 = 200
51+
defaultVolumeLimit int64 = 127
52+
readyState = "READY"
53+
standardDiskType = "pd-standard"
54+
extremeDiskType = "pd-extreme"
55+
provisionedIOPSOnCreate = "112345"
56+
provisionedIOPSOnCreateInt = int64(112345)
5657

5758
defaultEpsilon = 500000000 // 500M
5859
)
@@ -386,14 +387,21 @@ var _ = Describe("GCE PD CSI Driver", func() {
386387
// Create Disk
387388
disk := typeToDisk[diskType]
388389
volName := testNamePrefix + string(uuid.NewUUID())
389-
volume, err := client.CreateVolume(volName, disk.params, defaultSizeGb, nil, nil)
390+
391+
diskSize = defaultDiskSizeGb
392+
if disType = extremeDiskType {
393+
diskSize = defaultExtremeSizeGb
394+
}
395+
396+
volID, err := client.CreateVolume(volName, disk.params, diskSize, nil, nil)
397+
390398
Expect(err).To(BeNil(), "CreateVolume failed with error: %v", err)
391399

392400
// Validate Disk Created
393401
cloudDisk, err := computeService.Disks.Get(p, z, volName).Do()
394402
Expect(err).To(BeNil(), "Could not get disk from cloud directly")
395403
Expect(cloudDisk.Status).To(Equal(readyState))
396-
Expect(cloudDisk.SizeGb).To(Equal(defaultSizeGb))
404+
Expect(cloudDisk.SizeGb).To(Equal(diskSize))
397405
Expect(cloudDisk.Name).To(Equal(volName))
398406
disk.validate(cloudDisk)
399407

@@ -425,14 +433,19 @@ var _ = Describe("GCE PD CSI Driver", func() {
425433
params := merge(disk.params, map[string]string{
426434
common.ParameterKeyLabels: "key1=value1,key2=value2",
427435
})
428-
volume, err := client.CreateVolume(volName, params, defaultSizeGb, nil, nil)
436+
437+
diskSize = defaultDiskSizeGb
438+
if disType = extremeDiskType {
439+
diskSize = defaultExtremeSizeGb
440+
}
441+
volume, err := client.CreateVolume(volName, params, diskSize, nil, nil)
429442
Expect(err).To(BeNil(), "CreateVolume failed with error: %v", err)
430443

431444
// Validate Disk Created
432445
cloudDisk, err := computeService.Disks.Get(p, z, volName).Do()
433446
Expect(err).To(BeNil(), "Could not get disk from cloud directly")
434447
Expect(cloudDisk.Status).To(Equal(readyState))
435-
Expect(cloudDisk.SizeGb).To(Equal(defaultSizeGb))
448+
Expect(cloudDisk.SizeGb).To(Equal(diskSize))
436449
Expect(cloudDisk.Labels).To(Equal(map[string]string{
437450
"key1": "value1",
438451
"key2": "value2",
@@ -547,14 +560,19 @@ var _ = Describe("GCE PD CSI Driver", func() {
547560
},
548561
},
549562
}
550-
volume, err := controllerClient.CreateVolume(volName, params, defaultSizeGb, topology, nil)
563+
564+
diskSize = defaultDiskSizeGb
565+
if disType = extremeDiskType {
566+
diskSize = defaultExtremeSizeGb
567+
}
568+
volume, err := controllerClient.CreateVolume(volName, params, diskSize, topology, nil)
551569
Expect(err).To(BeNil(), "CreateVolume failed with error: %v", err)
552570

553571
// Validate Disk Created
554572
cloudDisk, err := computeService.Disks.Get(p, z, volName).Do()
555573
Expect(err).To(BeNil(), "Could not get disk from cloud directly")
556574
Expect(cloudDisk.Status).To(Equal(readyState))
557-
Expect(cloudDisk.SizeGb).To(Equal(defaultSizeGb))
575+
Expect(cloudDisk.SizeGb).To(Equal(diskSize))
558576
Expect(cloudDisk.Name).To(Equal(volName))
559577
disk.validate(cloudDisk)
560578

@@ -872,6 +890,11 @@ var _ = Describe("GCE PD CSI Driver", func() {
872890
controllerInstance := testContext.Instance
873891
controllerClient := testContext.Client
874892

893+
diskSize = defaultDiskSizeGb
894+
if disType = extremeDiskType {
895+
diskSize = defaultExtremeSizeGb
896+
}
897+
875898
p, z, _ := controllerInstance.GetIdentity()
876899

877900
// Create Disk
@@ -882,14 +905,14 @@ var _ = Describe("GCE PD CSI Driver", func() {
882905
common.ParameterKeyPVCNamespace: "test-pvc-namespace",
883906
common.ParameterKeyPVName: "test-pv-name",
884907
})
885-
volume, err := controllerClient.CreateVolume(volName, params, defaultSizeGb, nil /* topReq */, nil)
908+
volume, err := controllerClient.CreateVolume(volName, params, diskSize, nil /* topReq */, nil)
886909
Expect(err).To(BeNil(), "CreateVolume failed with error: %v", err)
887910

888911
// Validate Disk Created
889912
cloudDisk, err := computeService.Disks.Get(p, z, volName).Do()
890913
Expect(err).To(BeNil(), "Could not get disk from cloud directly")
891914
Expect(cloudDisk.Status).To(Equal(readyState))
892-
Expect(cloudDisk.SizeGb).To(Equal(defaultSizeGb))
915+
Expect(cloudDisk.SizeGb).To(Equal(diskSize))
893916
Expect(cloudDisk.Name).To(Equal(volName))
894917
Expect(cloudDisk.Description).To(Equal("{\"kubernetes.io/created-for/pv/name\":\"test-pv-name\",\"kubernetes.io/created-for/pvc/name\":\"test-pvc\",\"kubernetes.io/created-for/pvc/namespace\":\"test-pvc-namespace\",\"storage.gke.io/created-by\":\"pd.csi.storage.gke.io\"}"))
895918
disk.validate(cloudDisk)

0 commit comments

Comments
 (0)