Skip to content

Classify QUOTA_EXCEEDED errors as ResourceExhausted rather than Internal errors #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

judemars
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Classifies user-caused stockouts (QUOTA_EXCEEDED) as ResourceExhausted rather than Internal errors. This helps exclude user-caused issues from our SLOs and monitoring.

Does this PR introduce a user-facing change?:

Classifies QUOTA_EXCEEDED errors as ResourceExhausted rather than Internal errors.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: judemars
Once this PR has been reviewed and has the lgtm label, please assign leiyiz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 19, 2023
@judemars
Copy link
Contributor Author

/label tide/merge-method-squash
/assign @pwschuurman

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 19, 2023
@judemars judemars changed the title Stockouts Classify QUOTA_EXCEEDED errors as ResourceExhausted rather than Internal errors Jun 19, 2023
@judemars
Copy link
Contributor Author

Deleting in favor of https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1261/files which accomplishes this amongst other things

@judemars judemars closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants