-
Notifications
You must be signed in to change notification settings - Fork 159
Filter out user errors from GetDisk error returned from ControllerPublishVolume #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out user errors from GetDisk error returned from ControllerPublishVolume #1255
Conversation
/assign @saikat-royc |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.10 |
@amacaskill: new pull request created: #1256 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.9 |
@judemars: new pull request created: #1321 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.8 |
@judemars: new pull request created: #1380 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Filter out user errors from GetDisk error returned from ControllerPublishVolume. We are getting ControllerPublishVolume SLO violations because GetDisk returns a user error even though the error code is a 403 error. This is because we did not wrap the error with common.LoggedError in this spot. Examples of errors we are getting now, which will soon be replaced with proper grpc code:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: