Skip to content

Remove nouid32 which breaks xfs #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Jun 6, 2023

See kubernetes/cloud-provider-gcp#557 and this example of a failing test.

It appears the nouid32 mount option is not supported by XFS.

I guess it works with ext4 --- but brief internet searching didn't find anything about it, so I don't know if it's something we need to support?
/kind failing-test

None

/assign @msau42

Change-Id: Ib5e8c60fc06ac15ef82b313a2809a1380a3f3022
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@msau42
Copy link
Contributor

msau42 commented Jun 6, 2023

https://man7.org/linux/man-pages/man5/ext4.5.html

       nouid32
              Disables 32-bit UIDs and GIDs.  This is for
              interoperability with older kernels which only store and
              expect 16-bit values.

Sounds fine to remove. The test is only testing that mount options work, the specific options are not important.

@msau42
Copy link
Contributor

msau42 commented Jun 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit e867d8c into kubernetes-sigs:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants