Skip to content

Delete stable overlays and update docs with recommended versions. #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Jun 5, 2023

/kind cleanup

What this PR does / why we need it:

As part of cleaning up the testgrids (see https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver), we've decided to clean up the old k8s version overlays. We no longer have test jobs that verify that these overlays still actually work so it seems better not to promise as such.

None

/assign @msau42

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from leiyiz and msau42 June 5, 2023 23:26
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 5, 2023
Change-Id: I020fd4a3c81ac710df7dd931d6b2f6fd2457a734
@mattcary
Copy link
Contributor Author

Oops, I dropped this. I responded to your comments.

@mattcary
Copy link
Contributor Author

ping? @msau42

@msau42
Copy link
Contributor

msau42 commented Aug 28, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 52b1adc into kubernetes-sigs:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants