Skip to content

Automated cherry pick of #1212: Rewrite PD CSI error message when encountering diskType #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented May 12, 2023

Cherry pick of #1212 on release-1.7.

#1212: Rewrite PD CSI error message when encountering diskType

For details on the cherry pick process, see the cherry pick requests page.

Updates error message to be more user friendly when PD CSI Driver encounters an disk type UNSUPPORTED_OPERATION on ControllerPublishVolume

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2023
@k8s-ci-robot k8s-ci-robot requested review from jingxu97 and msau42 May 12, 2023 22:26
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 12, 2023
@mattcary
Copy link
Contributor

/hold

waiting for soak in 1.8+ release versions

@pwschuurman
Copy link
Contributor Author

@mattcary Can you approve this cherry pick? The 1.8+ version has been soaking for 3 weeks now

@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@sunnylovestiramisu
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@sunnylovestiramisu
Copy link
Contributor

/approve

1 similar comment
@msau42
Copy link
Contributor

msau42 commented Jun 26, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pwschuurman, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@sunnylovestiramisu
Copy link
Contributor

/retest

2 similar comments
@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8075e3d into kubernetes-sigs:release-1.7 Jun 26, 2023
@saikat-royc
Copy link
Member

/lgtm
/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants